I think that it would be a good idea to include these fixes in the next minor release. After working for a couple months on getting our embedded systems 2038 compliant, it has become very apparent that 2038 will be a substantial ordeal. Maximizing the number of systems that include this fix would make things a little easier when that time comes around.
Thanks, Max ________________________________ From: Nathan Bossart <nathandboss...@gmail.com> Sent: Thursday, September 26, 2024 9:38 PM To: Max Johnson <max.john...@novatechautomation.com> Cc: pgsql-hack...@postgresql.org <pgsql-hack...@postgresql.org>; t...@sss.pgh.pa.us <t...@sss.pgh.pa.us> Subject: Re: pg_ctl/miscinit: print "MyStartTime" as a long long instead of long to avoid 2038 problem. On Wed, Sep 25, 2024 at 08:04:59PM +0000, Max Johnson wrote: > I think your patch looks good, no objections. I am happy to have contributed. Great. I've attached what I have staged for commit. My first instinct was to not bother back-patching this since all currently-supported versions will have been out of support for over 8 years by the time this becomes a practical issue. However, I wonder if it makes sense to back-patch for the kinds of 32-bit embedded systems you cited upthread. I can imagine that such systems might need to work for a very long time without any software updates, in which case it'd probably be a good idea to make this fix available in the next minor release. What do you think? -- nathan
