On Sun, Sep 22, 2024 at 1:38 PM David Rowley <dgrowle...@gmail.com> wrote: > Just looking at the commit message: > > > The rationale is based on the assumption that incremental sort is > > always faster than full sort when there are presorted keys, a premise > > that has been applied in various parts of the code. This assumption > > does not always hold, particularly in cases with a large skew in the > > number of rows within the presorted groups. > > My understanding is that the worst case for incremental sort is the > same as sort, i.e. only 1 presorted group, which is the same effort to > sort. Is there something I'm missing?
I've pushed this patch after tweaking this part in the commit message. Thank you both for your reviews. Thanks Richard