On Wed, Oct 9, 2024 at 5:26 PM David Rowley <dgrowle...@gmail.com> wrote: > > On Thu, 10 Oct 2024 at 08:38, James Hunter <james.hunter...@gmail.com> wrote: > > We had two almost-identical copies of the utility function > > clause_sides_match_join() -- one in joinpath.c, and one in > > analyzejoins.c. Both copies were marked "inline," so we might as well > > just move the (inline) function definition into a common header file. > > I chose pathnode.h, because it is already #included by both of the .c > > files. > > I'm in favour of the deduplication. pathnode.h seems like a strange > choice. restrictinfo.h seems more suited.
Moved into restrictinfo.h, instead, in next revision. (The only reason I initially chose pathnode.h is because it was already #included by the two .c files; I agree, after glancing over restrictinfo.h, that it seems like a better fit.) > > (I really wonder how much the inlining is giving us given that the > function itself calls other non-inlineable functions) I wondered the same! But, at least the branch can be inlined? Thanks for looking over the patch, James
0001-Move-clause_sides_match_join-into-restrictinfo.h.patch
Description: Binary data
