On Thu, Oct 10, 2024 at 03:49:16PM -0400, Corey Huinker wrote: >> One other question I had when looking at this patch is whether we could >> remove dataOnly/schemaOnly from DumpOptions and RestoreOptions. Once 0007 >> is applied, those variables become particularly hazardous, so we really >> want to prevent folks from using them in new code. > > Well, the very next patch in the series adds --statistics-only, so I don't > think we're getting rid of user-facing command switches. However, I could > see us taking away the dataOnly/schemaOnly internal variables, thus > preventing coders from playing with those sharp objects.
That's what I meant. The user-facing options would stay the same, but the internal variables would be local to main() so that other functions would be forced to use dumpData, dumpSchema, etc. -- nathan
