On Sat, Oct 12, 2024 at 5:47 PM Noah Misch <n...@leadboat.com> wrote: > > Rebased.
Hi, I have a couple of questions : 1. In heap_inplace_update_and_unlock, currently both buffer and tuple are unlocked outside the critical section. Why do we have to move the buffer unlock within the critical section here? My guess is that it needs to be unlocked for the inplace invals to be processed. But what is the reasoning behind that? 2. Is there any benefit in CacheInvalidateHeapTupleCommon taking the preapre_callback argument? Wouldn't it be simpler to just pass an InvalidationInfo* to the function? Also is inval-requires-xid-v0.patch planned to be fixed up to inplace160? Thanks
