On 14.08.2024 09:32, Steven Niu wrote:
Hi, Kirill, Junwang,

I made this patch to address the refactor issue in our previous email discussion. https://www.postgresql.org/message-id/flat/CABBtG=cdtcbdcbk7mcsy6bjr3s5xutog0vsffuw8olduyyc...@mail.gmail.com

That is, the for loop in function smgrdestroy() and smgrdounlinkall can be replaced with smgrclose().

for (forknum = 0; forknum <= MAX_FORKNUM; forknum++)
    smgrsw[reln->smgr_which].smgr_close(reln, forknum);
-->
smgrclose(rels[i]);

Please let me know if you have any questions.

Best Regards,
Steven from Highgo.com

Hello,

Are you sure we can refactor loop by 'smgrclose()'? I see it is not quite the same.

Regards,
Ilia Evdokimov,
Tantor Labs LLC.



Reply via email to