On 14.10.2024 12:25, Alexander Kuznetsov wrote:
Hello everyone,
I'd like to propose adding a check for the nullness of tuplestorestate
before dereferencing it
in src/backend/executor/nodeModifier.c. The patch is attached.
I am proposing this fix based on the assumption that tuplestorestate
could be NULL
since there is a check for it when calculating eof_tuplestore at line 85.
However, since this code hasn't been changed since 2006 and hasn't
caused any issues,
it is possible that the check for (tuplestorestate == NULL) is
redundant when calculating eof_tuplestore.
Hi Alexander,
The 'tuplestorestate' variable may be initialized at line 64 if it is
NULL. You should consider initializing this variable earlier.
Regards,
Ilia Evdokimov,
Tantor Labs LLC.
