On Mon, Oct 28, 2024 at 8:47 AM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > Dear Shubham, > > Thanks for updating the patch! I resumed reviewing the patch set. > Here are only cosmetic comments as my rehabilitation. > > 01. getPublications() > > I feel we could follow the notation like getSubscriptions(), because number of > parameters became larger. How do you feel like attached? >
I will handle this comment in a later set of patches. > 02. fetch_remote_table_info() > > ``` > "SELECT DISTINCT" > - " (CASE WHEN (array_length(gpt.attrs, 1) = > c.relnatts)" > - " THEN NULL ELSE gpt.attrs END)" > + " (gpt.attrs)" > ``` > > I think no need to separate lines and add bracket. How about like below? > > ``` > "SELECT DISTINCT gpt.attrs" > ``` > Fixed this. The v44 version patches attached at [1] have the changes for the same. [1] - https://www.postgresql.org/message-id/CAHv8RjLvr8ZxX-1TcaxrZns1nwgrVUTO_2jhDdOPys0WgrDyKQ%40mail.gmail.com Thanks and Regards, Shubham Khanna.
