On Wed, Mar 27, 2024 at 4:49 AM Ajin Cherian <itsa...@gmail.com> wrote: > > > > On Mon, Mar 18, 2024 at 7:50 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: >> >> >> In addition to these changes, I've made some changes to the latest >> patch. Here is the summary: >> >> - Use txn_flags field to record the transaction status instead of two >> 'committed' and 'aborted' flags. >> - Add regression tests. >> - Update commit message. >> >> Regards, >> > > Hi Sawada-san, > > Thanks for the updated patch. Some comments: > > 1. > + * already aborted, we discards all changes accumulated so far and ignore > + * future changes, and return true. Otherwise return false. > > we discards/we discard
This comment is incorporated into the latest v5 patch I've just sent[1]. > > 2. In function ReorderBufferCheckTXNAbort(): I haven't tested this but I > wonder how prepared transactions would be considered, they are neither > committed, nor in progress. > IIUC prepared transactions are considered as in-progress. Regards, [1] https://www.postgresql.org/message-id/CAD21AoDJE-bLdxt9T_z1rw74RN%3DE0n0%2BesYU0eo%2B-_P32EbuVg%40mail.gmail.com -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
