On Fri, Oct 25, 2024 at 01:55:57PM +0200, Daniel Gustafsson wrote: > > On 14 Oct 2024, at 18:57, Bruce Momjian <br...@momjian.us> wrote: > > > What might be acceptable would be to add an option that would make > > pg_upgrade more tolerant of problems in many areas, that is a lot more > > research and discussion. > > I agree that the concept of having pg_upgrade perform (opt-in) skipping and/or > repairs of the old cluster warrants a larger discussion in its own thread. > There has been significant amount of energy spent recently to add structure to > the checks, any new feature should be properly designed for the get-go. > > In the meantime, the OP has a good point that it's a tad silly that pg_upgrade > fails hard on invalid databases instead of detecting and reporting like how > other errors are handled. The attached adds this check and expands the report > wording to cover it.
Agreed. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, "Am I going to die?", he means "Am I going to die soon?"
