On Tue, Jul 17, 2018 at 03:02:32PM -0400, Tom Lane wrote: > Cute idea, but it seems not to work with older versions of prove: > > $ which prove > /usr/local/perl5.8.3/bin/prove > $ prove --state=save > Unknown option: s
I didn't know this one, and that's actually nice, but I cannot get easily a way to track down which tests failed during a parallel run... And I am used as well to hunt those with "git status". > We could just do a "touch .prove_running" beforehand and an "rm" after, > perhaps (I think Michael suggested something like that already). Yes, except that in the idea of upthread TestLib.pm would be in control of it, so as there is less code churn in prove_check and prove_installcheck. But I am having second-thoughts about putting the test state directly in the module as that's a four-liner in Makefile.global.in, and that seems to work even if you put a die() to fail hard or even if only a subset of tests is failing. Thoughts? -- Michael
diff --git a/src/Makefile.global.in b/src/Makefile.global.in index 95d090e72d..fc81380ad2 100644 --- a/src/Makefile.global.in +++ b/src/Makefile.global.in @@ -417,15 +417,19 @@ endef ifeq ($(enable_tap_tests),yes) define prove_installcheck +touch '$(CURDIR)'/tap_running rm -rf '$(CURDIR)'/tmp_check $(MKDIR_P) '$(CURDIR)'/tmp_check cd $(srcdir) && TESTDIR='$(CURDIR)' PATH="$(bindir):$$PATH" PGPORT='6$(DEF_PGPORT)' top_builddir='$(CURDIR)/$(top_builddir)' PG_REGRESS='$(CURDIR)/$(top_builddir)/src/test/regress/pg_regress' $(PROVE) $(PG_PROVE_FLAGS) $(PROVE_FLAGS) $(if $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl) +rm '$(CURDIR)'/tap_running endef define prove_check +touch '$(CURDIR)'/tap_running rm -rf '$(CURDIR)'/tmp_check $(MKDIR_P) '$(CURDIR)'/tmp_check cd $(srcdir) && TESTDIR='$(CURDIR)' $(with_temp_install) PGPORT='6$(DEF_PGPORT)' PG_REGRESS='$(CURDIR)/$(top_builddir)/src/test/regress/pg_regress' $(PROVE) $(PG_PROVE_FLAGS) $(PROVE_FLAGS) $(if $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl) +rm '$(CURDIR)'/tap_running endef else
signature.asc
Description: PGP signature
