> On 1 Nov 2024, at 13:53, Peter Eisentraut <pe...@eisentraut.org> wrote: > > On 01.11.24 12:53, Alvaro Herrera wrote: >> On 2024-Oct-31, Daniel Gustafsson wrote: >>> When looking at our Git tree for a recent conference presentation I >>> happened to >>> notice that we have recently gained duplicate names in the shortlog. Not >>> sure >>> if we care enough to fix that with a .mailmap, but if we do the attached >>> diff >>> makes sure that all commits are accounted for a single committer entry. >> LGTM. I'd also add this line while at it: >> Peter Eisentraut <pe...@eisentraut.org> <pete...@gmx.net> >> This takes care of all the duplicate "identities" in the history AFAICT. > > I'm not sure if this is a good use of the mailmap feature. If someone > commits under <pe...@companyfoo.com> for a while and then later as > <pe...@companybar.com>, and the mailmap maps everything to the most recent > one, that seems kind of misleading or unfair? The examples on the gitmailmap > man page all indicate that this feature is to correct accidental variations > or obvious mistakes, but not to unify everything to the extent that it alters > the historical record.
I agree with this and propose to leave it at the originally proposed mailmap contents. -- Daniel Gustafsson
