On Sun, Nov 3, 2024 at 11:40 PM Amul Sul <sula...@gmail.com> wrote: > +1 for the back-patching. > > For 0002, I think we could report the error a bit earlier — the better > place might be in the else part of the following IF-block, IMO: > > /* > * If s->header_length == 0, then this is a full file; otherwise, it's > * an incremental file. > */ > if (s->header_length == 0)
We could, but I have some follow-up patches adding some new functionality which I plan to post soon, and for those patches, it turns out to be more convenient to have the error check where I put it. So I'm sticking with that placement. Committed and back-patched both to v17; thanks to both of you for the review. -- Robert Haas EDB: http://www.enterprisedb.com
