> On 4 Nov 2024, at 18:14, Tom Lane <t...@sss.pgh.pa.us> wrote: > perhaps under the illusion that dbname and connection_string can't > both be NULL.
Ugh, yes, I failed to capture that nuance. > I think the attached will fix it, but I wonder if there are edge > cases I'm not thinking of. +1 on your patch, reading through I can't see anything it misses. Maybe a comment above the change with a note on why dbname is tested for NULL there would be good? -- Daniel Gustafsson
