On Thu, Nov 14, 2024 at 5:13 PM Peter Eisentraut <pe...@eisentraut.org> wrote:
> On 14.11.24 15:35, Noah Misch wrote: > > The postgr.es/c/e54a42a standard would have us stop here. But I'm open > to > > treating the standard as mistaken and changing things. > > That text explicitly calls out that adding struct members at the end of > a struct is considered okay. But thinking about it now, even adding > fields to the end of a node struct that extensions allocate using > makeNode() is an ABI break that is liable to cause all affected > extensions to break in a crashing way. > I think it was mentioned elsewhere, but this wouldn't be a problem if makeNode was not a macro. -- Best wishes, Mats Kindahl, Timescale
