On Thu, 21 Nov 2024 at 06:43, Antonin Houska <[email protected]> wrote:
> When doing some unrelated work I noticed that in the new test
> 010_keep_recycled_wals.pl the server fails to reload the configuration
> file. The line it complains about is
>
> archive_command = '/usr/bin/perl -e 'exit(1)''
>
> The test still succeeds for some reason.
>
Oh, nice catch.
The attached patch should address it.
--
Regards,
--
Alexander Kukushkin
diff --git a/src/bin/pg_rewind/t/010_keep_recycled_wals.pl b/src/bin/pg_rewind/t/010_keep_recycled_wals.pl
index e6dfce2a54..c0765b699f 100644
--- a/src/bin/pg_rewind/t/010_keep_recycled_wals.pl
+++ b/src/bin/pg_rewind/t/010_keep_recycled_wals.pl
@@ -25,7 +25,7 @@ RewindTest::primary_psql("CHECKPOINT"); # last common checkpoint
# We use "perl -e 'exit(1)'" as an alternative to "false", because the latter
# might not be available on Windows.
-my $false = "$^X -e 'exit(1)'";
+my $false = "$^X -e \"exit(1)\"";
$node_primary->append_conf(
'postgresql.conf', qq(
archive_command = '$false'
