Andres Freund <and...@anarazel.de> writes:
> On 2024-12-03 22:06:59 +0200, Heikki Linnakangas wrote:
>> I spotted some more remnants of the "snapshot too old" feature that was
>> removed in v17. Barring objections, I will commit the attached patch to tidy
>> up.
> Most of this I agree with. But I'm not sure just removing the toast snapshot
> stuff is good - we've had a bunch of bugs where we don't hold a snapshot for
> long enough to actually ensure that toast tuples stay alive.
Yeah, the stuff concerned with toast snapshots has nothing to do
with that old user-visible feature. It's to keep us from writing
incorrect code, and it's still (very) needed.
regards, tom lane
