On 12/4/24 03:15, Peter Eisentraut wrote:
I did some more work on this approach, with the attached patches resulting. This is essentially
what I'm describing above, which in turn is a variation of your patch v45-0001-Fix-logical-
replication-for-temporal-tables.patch, with your tests added at the end.
I also did some more work on IsIndexUsableForReplicaIdentityFull() to make the various claims in the
comments reflected by actual code. With all of this, it can now also use gist indexes on the
subscriber side in cases of REPLICA IDENTITY FULL. This isn't immediately visible in the tests, but
you can see that the tests are using it internally by adding debugging elogs or something like that.
Altogether, I think this fixes the original problem of temporal keys not being handled properly in
logical replication subscribers, and it makes things less hardcoded around btree and hash in general.
Please review.
Thanks! Between U.S. Thanksgiving and the flu I haven't had a chance to look at your previous
patches, but I should have an evening or two this week to review what you've got here. I appreciate
your keeping the ball moving! I also have some notes about the Index AMI work I will write up on
that thread.
Yours,
--
Paul ~{:-)
p...@illuminatedcomputing.com
