On Thu, Dec 5, 2024 at 4:29 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@gmail.com> writes: > > Ahh, correction, it does define it (or else perl would have > > complained), but it seems that meson magically puts it into the > > compiler command line without being asked. So it is defined without > > pg_config.h being involved, and thus earlier. Huh. > > That does not seem great. Compile an extension without the same > CPPFLAGS, you silently get an ABI-incompatible module. We really > ought to be putting these ABI-critical flags into pg_config.h. > It's especially bad that this works differently between autoconf > and meson builds.
It makes the whole MinGW circus worse that I'd realised: https://www.postgresql.org/message-id/flat/CA%2BhUKG%2B6ZPD_X5ADMwX2uUtXqe_wv8%2BKQ5xFeAR2zbcodjNZvw%40mail.gmail.com#ddad894fcfa9733d30a579f7eb52ebf6
