On Tue, 10 Dec 2024 at 08:28, Michael Paquier <mich...@paquier.xyz> wrote:
> I would suggest to split the patch into two pieces for clarity, based > on the fact that your v7 patch is doing more than one thing at the > same time: > - Introduce new tests for the new coverage (domain, CREATE TABLE OF, > ALTER TABLE flavors) in a first patch. > - Introduce the ParseStates in these new code paths in a second patch. > > By structuring things this way, it is possible to see what kind of > difference related to the new ParseStates is introduced, based on the > new test coverage introduced in the first patch. > > This makes also the whole review easier. Ok. Sure. > Typo here: s/exists/exist/. Fixed, Thank you PFA v8. -- Best regards, Kirill Reshke
v8-0001-Add-more-regression-tests-to-various-DDL-patterns.patch
Description: Binary data
v8-0002-Print-out-error-position-for-number-of-DDL-comman.patch
Description: Binary data
