On Sat, 21 Dec 2024 at 17:06, jian he <jian.universal...@gmail.com> wrote: > * Note the definitions of the relevant flags in src/include/utility/tcop.h. > */ > static int > ClassifyUtilityCommandAsReadOnly(Node *parsetree) > > Is the comment wrong? > > it should be > " * Note the definitions of the relevant flags in src/include/tcop/utility.h."
Yeah. There is no tcop.h. I used the attached (not exactly very pretty) script to find a few more. git grep -h -E "\Wsrc/[\w_/]*" -- '*.[ch]' | tr -d '"' | tr -d \'\" | xargs -n 1 ./fileexists.sh | grep "does not" There are plenty of places that reference files not starting with "src/". It might be good to verify there's some subdirectory in the source tree that match those, however, I didn't think of a creative way to identify those ones. David
#!/bin/bash
set -o noglob
input=$1
input=$(echo $input | sed -r 's/^.*[\W\s](src\/[\W.\/]+)[\W\s]*/\1/')
input=$(echo $input | sed 's/[^[:alpha:]]\+$//')
if [ "$input" == "" ]; then
exit
fi
if [[ "$input" =~ ^src/ ]]; then
echo -n "Checking $input .. "
if [ -f $input ]; then
echo file exists
else
if [ -d $input ]; then
echo directory exists
else
echo does not exist
fi
fi
fi
fix_incorrect_filename_references.patch
Description: Binary data
