On Mon, 6 Jan 2025 at 23:05, Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Thu, Jan 02, 2025 at 02:05:13AM +0530, Mahendra Singh Thalor wrote: > > Here, I am attaching an updated patch. I fixed some bugs of v01 patch and > > did some code cleanup also. > > Thank you for picking this up! I started to review it, but the > documentation changes didn't build, and a few tests in check-world are > failing. Would you mind resolving those issues? Also, if you haven't > already, please add an entry to the next commitfest [0] to ensure that 1) > this feature is tracked and 2) the automated tests will run.
Thanks Nathan for the quick response. I fixed bugs of documentation changes and check-world in the latest patch. Now docs are building and check-world is passing. I added entry into commitfest for this patch.[0] <https://commitfest.postgresql.org/52/5495/> > > + if (dbfile) > + { > + printfPQExpBuffer(&cmd, "\"%s\" %s %s", pg_dump_bin, > + dbfile, create_opts); > + appendPQExpBufferStr(&cmd, " -F d "); > + } > > Have you given any thought to allowing a directory of custom format files, > as discussed upthread [1]? Perhaps that is better handled as a follow-up > patch, but it'd be good to understand the plan, anyway. I will make these changes and will test. I will update my findings after doing some testing. Apart from these bugs, I added code to handle --exclude-database= PATTERN. Earlier I was using NAME only to skip databases for restore. *TODO: .pl test cases for new added options.* Here, I am attaching an updated patch for review and feedback. > > [0] https://commitfest.postgresql.org > [1] https://postgr.es/m/CABUevExoQ26jo%2BaQ9QZq%2BUMA1aD6gfpm9xBnh_t5e0DhaCeRYA%40mail.gmail.com > > -- > nathan -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
v03-pg_dumpall-with-directory-format-and-restore-08_jan.patch
Description: Binary data
