> On 9 Jan 2025, at 02:45, Melanie Plageman <melanieplage...@gmail.com> wrote:
> Attached is v2 (required a rebase). I think this is a really good restructuring which will make life easier for our users. Some of the comments below are on wording which wasn't introduced in this patch, but which I hadn't thought about before, so feel free to ignore those comments. + <sect2 id="runtime-config-vacuum-freezing"> + <title>Freezing</title> + + <para> Trying to read this as a new user, I think it would be good to start this subsection with a sentence describing what freezing actually is. Vacuum is hard enough for users as it is =) + default value is one. Grepping around indicates that we typically use the numeric value rather than writing it in text, and the next settting down has "default value is 2". For consistency I would change that to "1" instead of "one". + <varname>vacuum_cost_delay</varname>. Then it will reset the counter and + continue execution. I know starting a sentence with "Then" is grammatically correct when it's the last sentence in a paragraph, but being a non-native speaker I always find myself re-reading such sentences to parse them as they stand out as odd. + can be set to fractional-millisecond values, such delays may not be + measured accurately on older platforms. On such platforms, This sentence seems quite vague and hard to act on for users, what qualifies as an "older platform" by the time v18 rolls around (this was added in v12). I'm sure there are such platforms in existence that postgres 18 will run on, but are we helping users with ambiguity? -- Daniel Gustafsson
