On Tue, 28 Jan 2025 at 10:19, Srinath Reddy <srinath2...@gmail.com> wrote: > > > Hi mahendra, > > I have reviewed the code in the v11 patch and it looks good to me. > > But in common_dumpall_restore.c there's parseDumpFormat which is common > between pg_dumpall and pg_restore ,as per the discussion in [1] thread i > don't think we should create a common api ,as discussed in the thread there > might chances in the future we might decide that some format is obsolete and > desupport it in pg_dumpall ,while support in pg_restore for compatibility > reasons. >
Oaky. Thanks for review. I will make changes as per discussion in another thread. On Tue, 28 Jan 2025 at 11:52, Srinath Reddy <srinath2...@gmail.com> wrote: > > make check-world fails,i think we don't need $port and $filename instead we > can use something like 'xxx'.so fixed it in the below patch. In offline discussion, Andew already reported this test case. I will fix this in the next version. > > Regards, > Srinath Reddy Sadipiralla, > EDB: http://www.enterprisedb.com > -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
