On Thu, Jan 30, 2025 at 3:02 AM Nazir Bilal Yavuz <byavu...@gmail.com> wrote: > > On Thu, 30 Jan 2025 at 00:38, Melanie Plageman > <melanieplage...@gmail.com> wrote: > > > > On Wed, Jan 22, 2025 at 4:24 PM Melanie Plageman > > <melanieplage...@gmail.com> wrote: > > > > > > 0001 is just the refactoring to push the setup into a helper. > > > 0002-0003 are required refactoring of the TBMIterateResult and > > > TBMIterator to support the read stream API. > > > 0004 implements using the read stream API and removing the old > > > prefetching code. > > > 0005 removes the table_scan_bitmap_next_block() callback, as it is not > > > really used anymore in BitmapHeapNext() to get the next block. > > > > > > I could use review feedback on all of them. 0001 should be ready to > > > push once I get some review. > > > > Bilal mentioned offlist that 0001 had some indentation issues in one > > of the comments. v27 attached. > > I have no other comments, 0001 LGTM.
Cool, thanks! I pushed v27-0001. Attached v28 is rebased and has a few updates/cleanup. All patches in the set need review and I need to do some benchmarking of v28-0003. - Melanie
v28-0003-BitmapHeapScan-uses-read-stream-API.patch
Description: Binary data
v28-0001-Hard-code-TBMIterateResult-offsets-array-size.patch
Description: Binary data
v28-0002-Separate-TBM-Shared-Private-Iterator-and-TBMIter.patch
Description: Binary data
v28-0004-Remove-table-AM-callback-scan_bitmap_next_block.patch
Description: Binary data
