On 2025-Feb-11, Sami Imseih wrote: > I have only looked at 0001, but I am wondering why > query_id_const_merge is a pg_stat_statements GUC > rather than a core GUC?
I was wondering the same thing and found the explanation here: https://postgr.es/m/ztmuctymis3n3...@paquier.xyz > Other extensions that consume queryIds may also want this > behavior without needing to enable pg_stat_statements. I agree. In fact, pg_stat_activity will behave differently (using merged query_ids) if this value is turned on, for which you need the contrib module. This makes no sense to me. Besides, the patch cheats in this regard: what Dmitry did was create a function SetQueryIdConstMerge() which the extension with the GUC can call to set the value of the variable. I really don't see that this is better. I think we should put the GUC back where it was in v15 of the patch. (I didn't check what other changes there were afterwards.) About the GUC name -- query_id_const_merge -- I think this is too much a hacker's name. How about query_id_merge_values query_id_merge_value_lists query_id_squash_constant_lists -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "No es bueno caminar con un hombre muerto"
