On 08.02.25 02:56, Jacob Champion wrote:
+ oauth_json_set_error(ctx, /* don't bother translating */
With the project style format for translator comments this should be:
+ /* translator: xxx */
+ oauth_json_set_error(ctx,
This comment was just meant to draw attention to the lack of
libpq_gettext(). Does it still need a translator note if we don't run
it through translation?
No, that wouldn't have any effect.
I think you can just remove that comment. It's pretty established that
internal errors don't need translation, so it would be understood from
looking at the code.