On Thu, Feb 13, 2025 at 6:52 PM Thomas Munro <thomas.mu...@gmail.com> wrote: > > I've been poking, reading, and trying out these patches. They look good to > me.
Thanks for the review. > Tiny nit, maybe this comment could say something less obvious, cf the > similar comment near the other stream: > > + /* Set up the read stream */ > + stream = read_stream_begin_relation(READ_STREAM_MAINTENANCE, Done in upthread v18. > I don't really love the cumbersome casting required around > per_buffer_data, but that's not your patches' fault (hmm, wonder what > we can do to improve that). I don't know if you saw v17, but I tried to improve it a bit. The casting still has to happen, but I at least use the variable as a uint8 instead of a pointer to a uint8 (dunno if that makes it better or worse). It is the same in v18. - Melanie
