Hi all, Please find attached a new version of this patch. I rebased on master, added better error reporting and skipped the permissions check on windows. Please let me know if this needs any changes. I tested this locally using meson running all TAP tests.
Thanks
On Fri, Jan 10, 2025 at 5:16 PM Abhishek Chanda <abhishek.b...@gmail.com> wrote:
>
> Thanks, Daniel. Here is an updated patch with all previous changes,
> added a simple connection test and another check to make sure file
> mode is correct, and the env var fix. Please let me know if anything
> needs to be changed. I tested this locally using meson running all TAP
> tests, and also manually.
>
> Thanks
> Abhishek
>
> On Fri, Jan 10, 2025 at 9:29 AM Daniel Gustafsson <dan...@yesql.se> wrote:
> >
> > > On 10 Jan 2025, at 04:59, Abhishek Chanda <abhishek.b...@gmail.com> wrote:
> >
> > Thanks for the new version.
> >
> > + {"sslkeylogfile", "SSLKEYLOGFILE",
> > The env var should be PGSSLKEYLOGFILE with the PG prefix.
> >
> > > 3. Added docs and tests
> >
> > There is no test in the attached patch, did you write one but forgot to git
> > add
> > it before committing locally?
> >
> > --
> > Daniel Gustafsson
> >
>
>
> --
> Thanks and regards
> Abhishek Chanda
--
Thanks and regards
Abhishek Chanda
v4-0001-Add-support-for-dumping-SSL-keylog-to-a-file.patch
Description: Binary data
