On Mon, Feb 24, 2025 at 12:57 PM Alexander Korotkov
<aekorot...@gmail.com> wrote:
> On Mon, Feb 24, 2025 at 12:12 AM Andrei Lepikhov <lepi...@gmail.com> wrote:
> > On 23/2/2025 22:15, Alexander Korotkov wrote:
> > > There is my attempt to implement this approach.  Getting rid of local
> > > variable (and computation of the same value other way) required to
> > > change arguments of remove_rel_from_eclass() as well.  I'm going to
> > > further polish this tomorrow.
> > I passed through the patch. It works correctly.
> >
> > Multiple ifs in a single routine is not ideal.
>
> I would say there is a brachcing anyway.  Even if it is inside
> adjust_relid_set().  Patch makes it more explicit.  Ideal or not, I
> don't think it gets worse.

I've added a commit message to the patch.  I'm going to push it if no
objections.

------
Regards,
Alexander Korotkov
Supabase

Attachment: v2-0001-Get-rid-of-ojrelid-local-variable-in-remove_rel_f.patch
Description: Binary data

Reply via email to