Masahiko,

I like the change you've made.

Thanks,
Andy Alsup

On Fri, Feb 28, 2025 at 2:05 PM Masahiko Sawada <sawada.m...@gmail.com>
wrote:

> On Thu, Feb 27, 2025 at 5:50 PM Andy Alsup <bluesbrea...@gmail.com> wrote:
> >
> > Masahiko,
> >
> > I have combined the gen_random_uuid() and uuidv4() into a single row, as
> you suggested. Please find the v5 patch, which has been squashed into a
> single commit.
>
> Thank you for updating the patch!
>
> I like that the patch adds the reference to the uuid data type. But I
> think we might want to adjust terminology:
>
> +  <para>
> +   See <xref linkend="datatype-uuid"/> for how details on the UUID
> datatype in
> +    <productname>PostgreSQL</productname>.
> +  </para>
>
> On 9.14. UUID Functions section, we use the word 'UUID' for data that
> are generated based on algorithms defined by RFC9562 whereas we use
> uuid (i.e., <type>uuid</type> in func.sgml) to a PostgreSQL data type.
> IIUC you want to refer 'UUID datatype' in the above change to the
> latter, PostgreSQL's uuid data type. Is that correct? If so, how about
> the following change?
>
>    See <xref linkend="datatype-uuid"/> for details on the data type
>    <type>uuid</type> in <productname>PostgreSQL</productname>.
>
> I've attached the updated patch that incorporates the above change,
> and updated the commit message too.
>
> Regards,
>
> --
> Masahiko Sawada
> Amazon Web Services: https://aws.amazon.com
>

Reply via email to