Hi,

On 2024-09-21 20:33:49 +0200, Tomas Vondra wrote:
> I've finally pushed this, after many rounds of careful testing to ensure
> no regressions, and polishing.

One minor nit: I don't like that FP_LOCK_SLOTS_PER_BACKEND is now non-constant
while looking like a constant:

#define         FP_LOCK_SLOTS_PER_BACKEND       (FP_LOCK_SLOTS_PER_GROUP * 
FastPathLockGroupsPerBackend)

I don't think it's a good idea to have non-function-like #defines that
reference variables that can change from run to run.

Greetings,

Andres Freund


Reply via email to