On 2025/03/05 9:32, Fujii Masao wrote:


On 2025/03/05 7:26, Jacob Champion wrote:
On Mon, Mar 3, 2025 at 10:02 PM Fujii Masao <masao.fu...@oss.nttdata.com> wrote:
I've pushed the patch. Thanks!

Hi all,

+tests += {
+  'name': 'ecpg',
+  'sd': meson.current_source_dir(),
+  'bd': meson.current_build_dir(),
+  'tap': {
+    'tests': [
+      't/001_ecpg_err_warn_msg.pl',
+      't/002_ecpg_err_warn_msg_informix.pl',
+    ],
+    'deps': ecpg_exe,
+  },
+}

My version of Meson is complaining about this use of 'deps':

     ../meson.build:3603: WARNING: Project targets '>=0.54' but uses
feature introduced in '0.60.0': list.<plus>. The right hand operand
was not a list.
     Adding test "ecpg/001_ecpg_err_warn_msg"
     ...

ecpg_exe should perhaps be wrapped in a list for now? I.e.

     -    'deps': ecpg_exe,
     +    'deps': [ecpg_exe],

Thanks for reporting this and suggesting a fix. I think you're right.

I confirmed that the compiler warning also appears in my environment,
and your fix resolves it. I’ve converted your fix into a patch, which is 
attached.

Unless there are any objections, I'm thinking to commit it.

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



Reply via email to