On Sun, Jul 29, 2018 at 5:49 PM, Thomas Munro
<thomas.mu...@enterprisedb.com> wrote:
> On Thu, May 10, 2018 at 7:08 AM, Robert Haas <robertmh...@gmail.com> wrote:
>>  [parallel-append-doc-v2.patch]
>
> +    plans just as they can in any other plan.  However, in a parallel plan,
> +    it is also possible that the planner may choose to substitute a
> +    <literal>Parallel Append</literal> node.
>
> Maybe drop "it is also possible that "?  It seems a bit unnecessary
> and sounds a bit odd followed by "may <verb>", but maybe it's just me.

Changed.

> +    Also, unlike a regular <literal>Append</literal> node, which can only 
> have
> +    partial children when used within a parallel plan, <literal>Parallel
> +    Append</literal> node can have both partial and non-partial child plans.
>
> Missing "a" before "<literal>Parallel".

Fixed.

> +    Non-partial children will be scanned by only a single worker, since
>
> Are we using "worker" in a more general sense that possibly includes
> the leader?  Hmm, yes, other text on this page does that too.  Ho hum.

Tried to be more careful about this.

New version attached.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment: parallel-append-doc-v3.patch
Description: Binary data

Reply via email to