On 2025-03-11 Tu 1:52 PM, Dagfinn Ilmari Mannsåker wrote:
Álvaro Herrera <alvhe...@alvh.no-ip.org> writes:
Hello,
On 2025-Mar-11, Mahendra Singh Thalor wrote:
In map.dat file, I tried to fix this issue by adding number of characters
in dbname but as per code comments, as of now, we are not supporting \n\r
in dbnames so i removed handling.
I will do some more study to fix this issue.
Yeah, I think this is saying that you should not consider the contents
of map.dat as a shell string. After all, you're not going to _execute_
that file via the shell.
Maybe for map.dat you need to escape such characters somehow, so that
they don't appear as literal newlines/carriage returns.
I haven't looked at the code for this, but why are we inventing an
ad-hoc file format? Why not use JSON, like we do for backup manifests?
Then storing arbitrary database names won't be a problem.
I'm not sure everyone thinks that was a good idea for backup manifests
(in fact I know some don't), and it seems somewhat like overkill for a
simple map of oids to database names.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
