Michael Paquier <[email protected]> writes:
> And I guess that we're OK here, so applied. That should be the last
> one.
Quite a few buildfarm members are not happy about the initialization
that 9a8dd2c5a added to PendingBackendStats. For instance [1]:
gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Werror=vla -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv
-fexcess-precision=standard -g -O2 -I. -I. -I../../../../src/include
-D_GNU_SOURCE -I/usr/include/libxml2 -c -o pgstat_backend.o pgstat_backend.c
pgstat_backend.c:39:1: warning: missing braces around initializer
[-Wmissing-braces]
static PgStat_BackendPending PendingBackendStats = {0};
^
pgstat_backend.c:39:1: warning: (near initialization for
\342\200\230PendingBackendStats.pending_io\342\200\231) [-Wmissing-braces]
I guess that more than one level of braces is needed for this to
be fully correct? Similar from ayu, batfish, boa, buri, demoiselle,
dhole, rhinoceros, shelduck, siskin.
regards, tom lane
[1]
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=arowana&dt=2025-03-11%2004%3A59%3A16&stg=build
