On Wed, Mar 12, 2025 at 12:00 AM Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Mon, Mar 10, 2025 at 10:08:49AM -0500, Nathan Bossart wrote: > > On Mon, Mar 10, 2025 at 12:35:22PM +0700, John Naylor wrote: > >> I have no further comments. > > > > Thanks. I'll give this a little more time for review before committing. > > I realized that we could limit the catalog query reuse to only when > --missing-only is specified, so I've updated 0001 and 0002 accordingly. > This avoids changing any existing behavior. > > > We'll still need to update the recommendation in pg_upgrade's > > documentation. I'm going to keep that separate because the stats > > import/export work is still settling. > > 0003 is a first attempt at this. Unless I am missing something, there's > really not much to update.
The change here seems fine. My only quibble is that this sentence now seems out of place: "Option --analyze-in-stages can be used to generate minimal statistics quickly." I'm thinking we should make a clearer separation for with and without the --no-statistics option specified. -- John Naylor Amazon Web Services
