On Fri, 14 Mar 2025 at 03:38, Daniel Gustafsson <dan...@yesql.se> wrote: > > > > > On 13 Mar 2025, at 19:31, Tom Lane <t...@sss.pgh.pa.us> wrote: > > > > Jacob Champion <jacob.champ...@enterprisedb.com> writes: > >> Adding the PG prefix to the envvar name addresses my collision > >> concern, but I think Tom's comment upthread [1] was saying that we > >> should not provide any envvar at all: > > > >>> I think it might be safer if we only accepted it as a connection > >>> parameter and not via an environment variable. > > > >> Is the addition of the PG prefix enough to address that concern too? > > > > Indeed, I was advocating for *no* environment variable. The PG prefix > > does not comfort me. > > Attached is a rebased version which fixes the test failure under autoconf (I > had missed git adding the configure file..) and Windows where the backslashes > weren't escaped properly. It also removes the environment variable and has > documentation touchups.
I noticed that Peter's comments from [1] is not yet addressed. I have changed the commitfest entry status to Waiting on Author, please address them and update the status to Needs review. [1] - https://www.postgresql.org/message-id/68b66b6d-cc59-44f8-bdd2-248d50055740%40eisentraut.org Regards. Vignesh
