On Mon, 3 Feb 2025 at 21:08, Dmitry Koval <d.ko...@postgrespro.ru> wrote: > > Hi, Alexander! > Thanks for your advices and recommendations! > > >I don't think we need a separate 0003 patch with refactoring. It's > >probably good idea to keep this functionality as a separate patch, but > >let's make then it a 0001, which prepares functions used by 0002 and > >0003. > > Done. 0003 was created separately to better understand what changes were > made after the verified changes 0001 and 0002. > > >Please, check my thoughts on how this patch could be further > >developed. Given amount of work to be done, I doubt that'a a subject > >for pg18. But I think you could continue this work, and we could > >consider it for early pg19 cycle. > > Good. I'll try to collect and summarize the opinions of colleagues on > these issues [1], and then put them up for discussion in this thread.
I noticed that Alvaro's comments from [1] have not yet been addressed, I have changed the status of commitfest entry to "Waiting on Author", please address them and update it to "Needs review". [1] - https://www.postgresql.org/message-id/202502031640.zem6orjmmxoz@alvherre.pgsql Regards, Vignesh
