On Thu, 13 Mar 2025 at 18:10, Heikki Linnakangas <hlinn...@iki.fi> wrote: > > Hmm, this problem isn't limited to this one pg_upgrade test, right? It > could happen with any pg_upgrade invocation. And perhaps in a running > server too, if a relfilenumber is reused quickly.
Yes, it can happen with these scenarios. > In dropdb() and DropTableSpace() we do this: > > WaitForProcSignalBarrier(EmitProcSignalBarrier(PROCSIGNAL_BARRIER_SMGRRELEASE)); > > Should we do the same here? Not sure where exactly to put that; perhaps > in mdcreate(), if the creation fails with STATUS_DELETE_PENDING. I felt mdcreate would be a good place to fix this issue. Regards, Vignesh