Dear Fujii-san,

> It looks like commit 0c013e08cfb introduced a bug that causes "pg_recvlogical
> --drop-slot"
> without --dbname to check whether it's connected to a specific database and 
> fail
> if it's not.
> 
> This commit was added before 9.5, while pg_recvlogical was introduced in 9.4. 
> On
> my env,
> "pg_recvlogical --drop-slot" without --dbname worked as expected in 9.4 but
> started
> failing in 9.5 or later.
> 
> So, I think the proper fix is to avoid raising a fatal error even when not 
> connected
> to
> a specific database in --drop-slot action.

+1. I created patch to fix it. 0001 was completely same as you did.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment: v3-0001-doc-Clarify-required-options-for-each-action-in-p.patch
Description: v3-0001-doc-Clarify-required-options-for-each-action-in-p.patch

Attachment: v3-0002-pg_recvlogical-allow-working-without-dbname-while.patch
Description: v3-0002-pg_recvlogical-allow-working-without-dbname-while.patch

Reply via email to