On Wed, Mar 19, 2025 at 12:29 PM Hayato Kuroda (Fujitsu) <kuroda.hay...@fujitsu.com> wrote: > > One comment for the API. Currently the patch introduces new option '--remove', > and the short term is '-r'. My suggestion is to use '-R' instead. > > Background > ========== > IIUC, we've planned to put outut-logs in some files on the directory [1]. > This follows what pg_ugprade does. > > In pg_uprade, -r means "retain SQL and log files even after successful > completion" [2]. > Normally logs would be removed after the sucessful upgrade, but they would > not with > the option. > > If we use -r for removing objects in pg_createsubscriber, it would be > conflicted > with the short term of --retain. This is confusing for users. >
We have discussed in the past and in this thread as well to have a functionality like pg_upgrade to have LOG and or SQL files in which case we may need to have an option for --retain (-r) similar to pg_upgrade. So, using -R for this option sounds reasonable to me. -- With Regards, Amit Kapila.
