On 2025/03/19 10:42, Nathan Bossart wrote:
On Mon, Mar 17, 2025 at 10:14:51AM -0500, Nathan Bossart wrote:
Thank you all for the discussion. I've attempted to address the
outstanding feedback into the new version of the patch.
Here is a new version of the patch with tests and some other light edits.
I feel like this is committable, but I'll wait for a couple more days for
any other feedback or objections.
+# - Default Behavior -
+
+#vacuum_truncate = on # enable truncation after vacuum
Since there's no existing GUC category that fits to vacuum_truncate,
I'm fine with adding a new category like "Vacuuming" and placing
vacuum_truncate there.
However, if we do this, ISTM that the new category should also be added to
guc_tables.h, and vacuum_truncate should be assigned to it in guc_tables.c.
Additionally, the documentation should be updated to include
the new category, with vacuum_truncate placed under it. Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
