On Fri, Mar 21, 2025 at 1:41 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > (and similarly in fix_upper_expr_mutator). So actually, I had broken > setrefs.c's matching of Params to lower plan levels with the > multi-assignment business, and Amit was dodging that breakage. > But this change is still wrong in itself: if anything, it should > have returned the Param, not treated it as a reference to the > child plan.
Ah ha! Well, that makes me feel a bit better -- perhaps what I committed wasn't the right way to fix it, but at least I wasn't just committing stuff totally at random. I'm happy to have you tidy up here in whatever way seems best to you. -- Robert Haas EDB: http://www.enterprisedb.com
