On Sat, Mar 22, 2025 at 6:23 PM vignesh C <vignes...@gmail.com> wrote: > > On Fri, 21 Mar 2025 at 18:59, Shubham Khanna > <khannashubham1...@gmail.com> wrote: > > > > > > During the recent testing, I observed that the tests were failing when > > using wait_for_slot_catchup(). To address this, I reverted to using > > wait_for_subscription_sync(), which was employed previously and has > > proven to be more reliable in ensuring test stability. > > Please let me know if there are any additional adjustments you would > > suggest or if you would like me to investigate further into > > wait_for_slot_catchup(). > > > > I have created a separate patch for the synopsis of '--all' option as > > suggested by Amit at [1]. The attached patch contains the suggested > > changes. > > I believe you added the following because pattern matching is > difficult for the $db1 and $db2 variables having special names: > +# Create a new database on node_p > +$node_p->safe_psql( > + "postgres", qq( > + CREATE DATABASE db1; > +)); > > How about we change it to verify the count of occurrences instead for > this case like below: > # Verify that the required logical replication objects are created. The > # expected count 3 refers to postgres, $db1 and $db2 databases. > is(scalar(() = $stderr =~ /creating publication/g), > 3, "verify publications are created for all databases"); > is(scalar(() = $stderr =~ /creating the replication slot/g), > 3, "verify replication slots are created for all databases"); > is(scalar(() = $stderr =~ /creating subscription/g), > 3, "verify subscriptions are created for all databases"); > > If you are ok, you can merge the changes attached. >
I agree that verifying the count of occurrences is a more straightforward and effective approach, especially given the challenges with pattern matching for $db1 and $db2 variables with special names. This method simplifies validation and enhances robustness by explicitly ensuring the expected number of logical replication objects are created. I have reviewed and merged the proposed changes into the patch. The attached patches contain the suggested changes. Thanks and regards, Shubham Khanna.
v18-0003-Synopsis-for-all-option.patch
Description: Binary data
v18-0001-Enhance-pg_createsubscriber-to-fetch-and-append-.patch
Description: Binary data
v18-0002-Additional-test-cases.patch
Description: Binary data
