Hi, On 2025-03-25 13:07:49 +1300, Thomas Munro wrote: > On Tue, Mar 25, 2025 at 11:55 AM Andres Freund <and...@anarazel.de> wrote: > > #define READ_STREAM_USE_BATCHING 0x08 > > +1 > > I wonder if something more like READ_STREAM_CALLBACK_BATCHMODE_AWARE > would be better, to highlight that you are making a declaration about > a property of your callback, not just turning on an independent > go-fast feature... I fished those words out of the main (?) > description of this topic atop pgaio_enter_batchmode(). Just a > thought, IDK.
The relevant lines are already very deeply indented, so I'm a bit wary of such a long name. I think we'd basically have to use a separate flags variable everywhere and that is annoying due to us following C89 variable declaration positions... Greetings, Andres Freund
