> > If this GUC sticks around, it should be at least PGC_SUSET (on > > the analogy of compute_query_id) to make it harder to break > > pg_stat_statements that way. > > I have no problem making it superuser-only, and I can see making "on" be > the default. I am not opposed to removing it completely either, if we > really think that the current behavior is no longer useful for anybody.
I am in favor of complete removal. [1] will change the behavior of table jumbling without introducing a GUC, and I don't think we should introduce a GUC for the squash values case either. Why one behavior change is configurable while the other is not? seems confusing, IMO. Also, as a matter of principle, it seems most are favoring not introducing GUCs to configure queryId behavior. I agree. [1] https://www.postgresql.org/message-id/flat/CAA5RZ0uNofEXfEfNw3uRN3D3oXkFPQ_s%2BhuLLHMKR_%2BMCk8RPQ%40mail.gmail.com#c357c56c3924642e8ef73cc1c8a0286e -- Sami Imseih Amazon Web Services (AWS)
