The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation: not tested
Hi Dmitrii, Paul Jungwirth and I reviewed this patch, and here are our comments: 1. The patch applies and tests pass. 2. The patch fixes a bug in contrib/spi, which is not really a practical extension, but rather examples of how to use SPI. The contrib/spi directory actually has four extensions: refint, autoinc, insert_username, and moddatetime. The patch is for refint, which is a way you could implement foreign keys if it weren't built in to Postgres. 3. Consider updating documentation for doc/src/contrib-spi.sgml, or any file as appropriate, to reflect the changes. 4. Are there any cases where check_primary_key() and check_foreign_key() should be called using a BEFORE trigger? Will this change break backwards compatibility? Consider adding a test with a BEFORE trigger to ensure the error "must be fired by AFTER trigger" is raised. Thank you! The new status of this patch is: Waiting on Author
