On Tue, Mar 25, 2025 at 4:01 PM Etsuro Fujita <etsuro.fuj...@gmail.com> wrote: > > In the patch I also fixed a bug; I trusted XactReadOnly to see if the > local transaction is READ ONLY, but I noticed that that is not 100% > correct, because a transaction which started as READ WRITE can show as > READ ONLY later within subtransactions, so I modified the patch so > that postgres_fdw opens remote transactions in READ ONLY mode if the > local transaction has been declared READ ONLY at the top level.
Nice catch. postgres_fdw replicates the transaction stack on foreign server. I think we need to replicate it along with the transaction properties. And also we need a test which tests readonly subtransaction behaviour. -- Best Wishes, Ashutosh Bapat
