Hello I think you should remove numa_warn() and numa_error() from 0001. AFAICS they are dead code (even with all your patches applied), and furthermore would get you in trouble regarding memory allocation because src/port is not allowed to use palloc et al. If you wanted to keep them you'd have to have them in src/common, but looking at the rest of the code in that patch, ISTM src/port is the right place for it. If in the future you discover that you do need numa_warn(), you can create a src/common/ file for it then.
Is pg_buffercache really the best place for these NUMA introspection routines? I'm not saying that it isn't, maybe we're okay with that (particularly if we can avoid duplicated code), but it seems a bit weird to me. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "No me acuerdo, pero no es cierto. No es cierto, y si fuera cierto, no me acuerdo." (Augusto Pinochet a una corte de justicia)
